Skip to content

fix(backup-list-fragment): permission handling#17315

Open
alperozturk96 wants to merge 4 commits into
masterfrom
fix/backup-list-fragment-permission-handling
Open

fix(backup-list-fragment): permission handling#17315
alperozturk96 wants to merge 4 commits into
masterfrom
fix/backup-list-fragment-permission-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Issue

Exception java.lang.SecurityException:
  at android.os.Parcel.createExceptionOrNull (Parcel.java:3388)
  at android.os.Parcel.createException (Parcel.java:3372)
  at android.os.Parcel.readException (Parcel.java:3355)
  at android.os.Parcel.readException (Parcel.java:3297)
  at android.app.IActivityManager$Stub$Proxy.getContentProvider (IActivityManager.java:6773)
  at android.app.ActivityThread.acquireProvider (ActivityThread.java:9501)
  at android.app.ContextImpl$ApplicationContentResolver.acquireProvider (ContextImpl.java:4185)
  at android.content.ContentResolver.acquireProvider (ContentResolver.java:2508)
  at android.content.ContentResolver.acquireContentProviderClient (ContentResolver.java:2586)
  at third_parties.sufficientlysecure.AndroidCalendar.missing (AndroidCalendar.java:116)
  at third_parties.sufficientlysecure.AndroidCalendar.loadAll (AndroidCalendar.java:56)
  at com.owncloud.android.ui.fragment.contactsbackup.BackupListAdapter.<init> (BackupListAdapter.kt:71)
  at com.owncloud.android.ui.fragment.contactsbackup.BackupListFragment.onCreateView (BackupListFragment.java:146)
  at androidx.fragment.app.Fragment.performCreateView (Fragment.java:3119)
  at androidx.fragment.app.FragmentStateManager.createView (FragmentStateManager.java:577)
  at androidx.fragment.app.FragmentStateManager.moveToExpectedState (FragmentStateManager.java:286)
  at androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:2214)
  at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:2109)
  at androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:2052)
  at androidx.fragment.app.FragmentManager.dispatchStateChange (FragmentManager.java:3327)
  at androidx.fragment.app.FragmentManager.dispatchActivityCreated (FragmentManager.java:3237)
  at androidx.fragment.app.FragmentController.dispatchActivityCreated (FragmentController.java:263)
  at androidx.fragment.app.FragmentActivity.onStart (FragmentActivity.java:350)
  at androidx.appcompat.app.AppCompatActivity.onStart (AppCompatActivity.java:238)
  at com.owncloud.android.ui.activity.DrawerActivity.onStart (DrawerActivity.java:1346)
  at com.owncloud.android.ui.activity.FileActivity.onStart (FileActivity.java:280)
  at android.app.Instrumentation.callActivityOnStart (Instrumentation.java:1719)
  at android.app.Activity.performStart (Activity.java:9796)
  at android.app.ActivityThread.handleStartActivity (ActivityThread.java:5075)
  at android.app.servertransaction.TransactionExecutor.performLifecycleSequence (TransactionExecutor.java:214)
  at android.app.servertransaction.TransactionExecutor.cycleToPath (TransactionExecutor.java:194)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleItem (TransactionExecutor.java:166)
  at android.app.servertransaction.TransactionExecutor.executeTransactionItems (TransactionExecutor.java:101)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:80)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:3287)
  at android.os.Handler.dispatchMessage (Handler.java:132)
  at android.os.Looper.dispatchMessage (Looper.java:358)
  at android.os.Looper.loopOnce (Looper.java:288)
  at android.os.Looper.loop (Looper.java:392)
  at android.app.ActivityThread.main (ActivityThread.java:10346)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:638)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:972)

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29094694504/artifacts/8228378655
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96

alperozturk96 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

@tobiasKaminsky how can i test this screen?

Screenshot 2026-07-10 at 15 09 57

tobiasKaminsky
tobiasKaminsky previously requested changes Jul 15, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListFragment.java Outdated
@alperozturk96
alperozturk96 force-pushed the fix/backup-list-fragment-permission-handling branch from 2b2ac88 to e53a87c Compare July 22, 2026 06:24
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29896663168/artifacts/8520375452
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
catch security exception
a9c8502 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
expose reloadCalendars method
f2ab75b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
handle permissions
77d8123 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
check permissions before load calendar
d3e10c0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/backup-list-fragment-permission-handling branch from bc1cf99 to d3e10c0 Compare July 22, 2026 07:26
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total399399

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29900230237/artifacts/8521877867
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17315-IT-master-10-50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 34.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky